fix: tolerate missing artifacts and reuse-bundle collisions#438
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Partial artifact sets can still be ingested into the DB, so outages may surface as incomplete data rather than a hard workflow failure.
Overview
Makes the ingest-results workflow and reuse-bundle flattening best-effort instead of failing the whole run when individual artifacts are missing or collide.
Artifact download: Failed downloads and failed
unzipsteps are logged as warnings, the bad artifact is skipped, and ingest continues with whatever downloaded successfully. The job only fails if no artifacts could be retrieved at all.Reuse bundle flattening: When a reused artifact name already exists at the artifact root (the run produced a fresher copy), the workflow and
flattenReusedIngestArtifactBundlenow warn, drop the reused copy, and keep the run-local artifact instead of erroring out. Tests were updated for this collision behavior.Reviewed by Cursor Bugbot for commit 1ad4bb1. Bugbot is set up for automated code reviews on this repo. Configure here.